Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hyrax Batch Ingest to Valkyrie #817

Closed
wants to merge 7 commits into from
Closed

Conversation

orangewolf
Copy link
Collaborator

No description provided.

alishaevn
alishaevn previously approved these changes Dec 20, 2023
Copy link
Collaborator

@alishaevn alishaevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk the context behind this, but from a "does this code work" perspective, it looks fine to me.

app/models/hyrax/pcdm_collection_decorator.rb Outdated Show resolved Hide resolved
@orangewolf orangewolf dismissed alishaevn’s stale review December 20, 2023 20:57

The merge-base changed after approval.

alishaevn
alishaevn previously approved these changes Dec 20, 2023
@orangewolf orangewolf dismissed alishaevn’s stale review December 20, 2023 21:13

The merge-base changed after approval.

alishaevn
alishaevn previously approved these changes Dec 20, 2023
@orangewolf orangewolf dismissed alishaevn’s stale review December 20, 2023 21:18

The merge-base changed after approval.

@orangewolf orangewolf closed this Dec 20, 2023
@orangewolf orangewolf deleted the batch_overhaul branch December 20, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants